Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix typing hit for envelope parse model #286

Merged
merged 1 commit into from
Feb 12, 2021
Merged

fix: fix typing hit for envelope parse model #286

merged 1 commit into from
Feb 12, 2021

Conversation

nmoutschen
Copy link
Contributor

@nmoutschen nmoutschen commented Feb 11, 2021 •
edited
Loading

Issue #, if available: #285

Description of changes:

Change the type hinting signature for aws_lambda_powertools.utilities.parser.envelopes.*Envelope

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Feb 11, 2021 •
edited
Loading

Codecov Report

Merging #286 (29fd31f) into develop (7b23b5b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #286   +/-   ##
========================================
  Coverage    99.75%   99.75%           
========================================
  Files           79       79           
  Lines         2859     2859           
  Branches       119      119           
========================================
  Hits          2852     2852           
  Misses           5        5           
  Partials         2        2
Impacted Files Coverage Δ
...mbda_powertools/utilities/parser/envelopes/base.py 100.00% <100.00%> (ø)
...owertools/utilities/parser/envelopes/cloudwatch.py 100.00% <100.00%> (ø)
..._powertools/utilities/parser/envelopes/dynamodb.py 100.00% <100.00%> (ø)
...ertools/utilities/parser/envelopes/event_bridge.py 100.00% <100.00%> (ø)
...a_powertools/utilities/parser/envelopes/kinesis.py 100.00% <100.00%> (ø)
...ambda_powertools/utilities/parser/envelopes/sns.py 100.00% <100.00%> (ø)
...ambda_powertools/utilities/parser/envelopes/sqs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b23b5b...29fd31f. Read the comment docs.

zroger
zroger approved these changes Feb 11, 2021
View reviewed changes
Copy link

@zroger zroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

@heitorlessa heitorlessa merged commit bf66299 into aws-powertools:develop Feb 12, 2021
@heitorlessa
Copy link
Contributor

Thank you @nmoutschen !!!

@heitorlessa heitorlessa added area/utilities bug Something isn't working labels Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroger zroger zroger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmoutschen @codecov-io @heitorlessa @zroger